Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regenerate files based on latest code changes #489

Merged
merged 1 commit into from
Dec 3, 2024

Conversation

shish
Copy link
Collaborator

@shish shish commented Dec 2, 2024

After #486 #487 and #488 are merged, running ./.devcontainer/build.sh produces this output, which contains a couple of years worth of updates - after those and this are merged, the github cronjob should submit incremental updates as PRs automatically

@shish shish force-pushed the regen branch 2 times, most recently from d5d8e90 to 3e050d0 Compare December 2, 2024 17:48
@shish
Copy link
Collaborator Author

shish commented Dec 2, 2024

Gah, the generated code doesn't match our own coding standards, and build.sh is missing the formatting >.>

@shish shish marked this pull request as draft December 2, 2024 18:01
@shish
Copy link
Collaborator Author

shish commented Dec 2, 2024

Generation now works fully \o/

Buuuuuuut... because the PHP documentation is incompatible with php8.1, and we generate code based on that documentation, we end up generating code that is incompatible with php8.1

(I still think this PR should be merged, because the failure is an accurate and correct representation of our current status, and it will at least bring our generat-or and generat-ed parts in-sync)

@shish shish marked this pull request as ready for review December 2, 2024 19:15
@shish shish merged commit 08a716a into thecodingmachine:master Dec 3, 2024
11 of 12 checks passed
@shish shish deleted the regen branch December 3, 2024 08:08
@staabm
Copy link
Collaborator

staabm commented Dec 3, 2024

thanks. wdyt how many PR are missing, until we can release a first beta?

@shish
Copy link
Collaborator Author

shish commented Dec 3, 2024

I hadn't planned that far ahead, #499 for keeping track of things-to-do-before-release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants